Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: lib/src/rules/overriden_field.dart

Issue 1991283003: Fix `overriden_field` false positive (#246). (Closed) Base URL: https://github.com/dart-lang/linter.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/_data/overridden_field/lintconfig.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/rules/overriden_field.dart
diff --git a/lib/src/rules/overriden_field.dart b/lib/src/rules/overriden_field.dart
index 0f608abc8199085a159fc0b951db0f35581edc4c..c9933484b2ce6056882a96639061ba776171d8b1 100644
--- a/lib/src/rules/overriden_field.dart
+++ b/lib/src/rules/overriden_field.dart
@@ -113,8 +113,9 @@ class _Visitor extends SimpleAstVisitor {
PropertyAccessorElement _getOverriddenMember(Element member) {
String memberName = member.name;
+ LibraryElement library = member.library;
bool isOverriddenMember(PropertyAccessorElement a) =>
- a.isSynthetic && a.name == memberName;
+ a.library == library && a.isSynthetic && a.name == memberName;
bool containsOverridenMember(InterfaceType i) =>
i.accessors.any(isOverriddenMember);
ClassElement classElement = member.enclosingElement;
« no previous file with comments | « no previous file | test/_data/overridden_field/lintconfig.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698