third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1991273003: Fire visibilityChange event on out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 232f3c593beb414be2093ec2270a1dda1909f84b..415045dfe4b84fc9cdc4917fec23f1fead2cffd7 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1807,7 +1807,7 @@ WebLocalFrameImpl* WebLocalFrameImpl::localRoot()

// when the WebLocalFrame exists but the core LocalFrame does not.

// TODO(alexmos, dcheng): Clean this up to only calculate this in one place.

WebLocalFrameImpl* localRoot = this;

- while (!localRoot->frameWidget())

+ while (localRoot->parent() && localRoot->parent()->isWebLocalFrame())

localRoot = toWebLocalFrameImpl(localRoot->parent());

return localRoot;

}

« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »