third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp - Issue 1991273003: Fire visibilityChange event on out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_frame_impl.cc ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

index d77df7fe0a8c249d522fed99316807db8233cd8d..8e5c72e8872f74790c449045990ac52310b0bfd8 100644

--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

@@ -74,7 +74,7 @@ public:

protected:

void SetUp() override

{

- m_webView = toWebViewImpl(WebView::create(&m_webViewClient));

+ m_webView = toWebViewImpl(WebView::create(&m_webViewClient, WebPageVisibilityStateVisible));

m_mainFrame = WebLocalFrame::create(WebTreeScopeType::Document, &m_webFrameClient);

m_webView->setMainFrame(m_mainFrame);

m_chromeClientImpl = toChromeClientImpl(&m_webView->page()->chromeClient());