components/printing/renderer/print_web_view_helper.cc - Issue 1991273003: Fire visibilityChange event on out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/plugins/renderer/webview_plugin.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | content/renderer/media/android/media_info_loader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index 1a1fdf0762d925d6fdc24496a1eac6283ced1261..0a636ca2822fb1b3b98c4ab983bcc5d73a551e32 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -522,7 +522,8 @@ void PrintWebViewHelper::PrintHeaderAndFooter(

page_layout.margin_top + page_layout.margin_bottom +

page_layout.content_height);

- blink::WebView* web_view = blink::WebView::create(NULL);

+ blink::WebView* web_view =

+ blink::WebView::create(nullptr, blink::WebPageVisibilityStateVisible);

web_view->settings()->setJavaScriptEnabled(true);

blink::WebLocalFrame* frame =

@@ -739,7 +740,8 @@ void PrepareFrameAndViewForPrint::CopySelection(

WebPreferences prefs = preferences;

prefs.javascript_enabled = false;

- blink::WebView* web_view = blink::WebView::create(this);

+ blink::WebView* web_view =

+ blink::WebView::create(this, blink::WebPageVisibilityStateVisible);

owns_web_view_ = true;

content::RenderView::ApplyWebPreferences(prefs, web_view);

web_view->setMainFrame(