Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android test+naming Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 905d7365cc9cec5397c4eedc2e66a98e6d0254fb..3664488607f43930531454594638cabe29c46c6b 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -539,7 +539,7 @@ TEST_F(WebViewTest, SetBaseBackgroundColorBeforeMainFrame)
{
const WebColor kBlue = 0xFF0000FF;
FrameTestHelpers::TestWebViewClient webViewClient;
- WebViewImpl* webView = WebViewImpl::create(&webViewClient);
+ WebViewImpl* webView = WebViewImpl::create(&webViewClient, true);
EXPECT_NE(kBlue, webView->backgroundColor());
// webView does not have a frame yet, but we should still be able to set the background color.
webView->setBaseBackgroundColor(kBlue);
@@ -1597,7 +1597,7 @@ TEST_F(WebViewTest, ClientTapHandling)
TEST_F(WebViewTest, ClientTapHandlingNullWebViewClient)
{
- WebViewImpl* webView = WebViewImpl::create(nullptr);
+ WebViewImpl* webView = WebViewImpl::create(nullptr, true);
WebLocalFrame* localFrame = WebLocalFrame::create(WebTreeScopeType::Document, nullptr);
webView->setMainFrame(localFrame);
WebGestureEvent event;

Powered by Google App Engine
This is Rietveld 408576698