Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android test+naming Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 3e7cbe11ca6bf9114ed2f3e894e93a830f9c56ec..183b4fab5ed38156fe28d65ced4b9b6a36096bb3 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -1768,7 +1768,8 @@ int RenderFrameHostManager::CreateRenderFrameProxy(SiteInstance* instance) {
if (!render_view_host) {
CHECK(frame_tree_node_->IsMainFrame());
render_view_host = frame_tree_node_->frame_tree()->CreateRenderViewHost(
- instance, MSG_ROUTING_NONE, MSG_ROUTING_NONE, true, true);
+ instance, MSG_ROUTING_NONE, MSG_ROUTING_NONE, true,
+ delegate_->IsHidden());
Charlie Reis 2016/06/06 23:15:09 This scares me a bit, but maybe it's ok. 1) We're
lfg 2016/06/08 20:00:22 That's right, the page visibility is determined by
Charlie Reis 2016/06/08 21:39:07 Acknowledged.
}
RenderFrameProxyHost* proxy = GetRenderFrameProxyHost(instance);

Powered by Google App Engine
This is Rietveld 408576698