third_party/WebKit/Source/core/page/Page.cpp - Issue 1991273003: Fire visibilityChange event on out-of-process iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | third_party/WebKit/public/web/WebFrameClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index 82058afac1f57815432cc43513d18efd05ce3340..aa8c2907753f2125ef3adaf225a2a21917e30c2e 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -355,8 +355,8 @@ void Page::setVisibilityState(PageVisibilityState visibilityState, bool isInitia

if (!isInitialState)

notifyPageVisibilityChanged();

- if (!isInitialState && m_mainFrame && m_mainFrame->isLocalFrame())

- deprecatedLocalMainFrame()->didChangeVisibilityState();

+ if (!isInitialState && m_mainFrame)

+ m_mainFrame->didChangeVisibilityState();

// Compress CompressibleStrings when 10 seconds have passed since the page

// went to background.