Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1991273002: Address comments on 88686a82ed8f1037bba3deacdd679fb8e717f2f6 (Closed)

Created:
4 years, 7 months ago by nellyv
Modified:
4 years, 7 months ago
Reviewers:
nelly, viettrungluu, ppi
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Address comments on 88686a82ed8f1037bba3deacdd679fb8e717f2f6 Add a comment on BUILD files that create a seemingly redundant library. The comment: "Library that allows to include the service code directly into the embedding shell. Used by https://manganese.googlesource.com/" BUG= R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8d66e0d091ffaf332a1ea75d6c37232ad9f3ec36

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M services/authenticating_url_loader_interceptor/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/files/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/icu_data/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/tracing/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/input_manager/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/launcher/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nelly
Hi Trung and Przemek, Ptal.
4 years, 7 months ago (2016-05-19 17:43:42 UTC) #2
viettrungluu
lgtm otherwise https://codereview.chromium.org/1991273002/diff/1/services/authenticating_url_loader_interceptor/BUILD.gn File services/authenticating_url_loader_interceptor/BUILD.gn (right): https://codereview.chromium.org/1991273002/diff/1/services/authenticating_url_loader_interceptor/BUILD.gn#newcode20 services/authenticating_url_loader_interceptor/BUILD.gn:20: # Library that allows to include the ...
4 years, 7 months ago (2016-05-19 20:30:38 UTC) #3
nelly
https://codereview.chromium.org/1991273002/diff/1/services/authenticating_url_loader_interceptor/BUILD.gn File services/authenticating_url_loader_interceptor/BUILD.gn (right): https://codereview.chromium.org/1991273002/diff/1/services/authenticating_url_loader_interceptor/BUILD.gn#newcode20 services/authenticating_url_loader_interceptor/BUILD.gn:20: # Library that allows to include the service code ...
4 years, 7 months ago (2016-05-20 08:59:22 UTC) #4
nellyv
Committed patchset #2 (id:20001) manually as 8d66e0d091ffaf332a1ea75d6c37232ad9f3ec36 (presubmit successful).
4 years, 7 months ago (2016-05-20 09:00:17 UTC) #6
ppi
4 years, 7 months ago (2016-05-20 09:01:17 UTC) #7
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698