Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: chrome/browser/extensions/extension_util.cc

Issue 1991263003: Enables EXTERNAL_COMPONENT extensions in incognito by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to benwells@ Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_util.cc
diff --git a/chrome/browser/extensions/extension_util.cc b/chrome/browser/extensions/extension_util.cc
index 4a861653b6ebb4e3906532324f16a8e501d3f259..97796a6d4d3e7ad22c34607874c6c10287733b2e 100644
--- a/chrome/browser/extensions/extension_util.cc
+++ b/chrome/browser/extensions/extension_util.cc
@@ -126,8 +126,10 @@ bool IsIncognitoEnabled(const std::string& extension_id,
return false;
// If this is an existing component extension we always allow it to
// work in incognito mode.
- if (extension->location() == Manifest::COMPONENT)
+ if (extension->location() == Manifest::COMPONENT ||
+ extension->location() == Manifest::EXTERNAL_COMPONENT) {
return true;
+ }
if (IsWhitelistedForIncognito(extension))
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698