Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1991263002: Android Site Settings: Re-order the permission list. (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 7 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Site Settings: Re-order the permission list. Covers both the top-level categories and permission list within the Site Details. No functionality should change as a result. BUG=610358 Committed: https://crrev.com/aa39cd5f1a36659f95c7eb9c532d97f38536db21 Cr-Commit-Position: refs/heads/master@{#396011}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M chrome/android/java/res/xml/single_website_preferences.xml View 1 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/android/java/res/xml/site_settings_preferences.xml View 1 3 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Finnur
4 years, 7 months ago (2016-05-23 11:03:52 UTC) #4
Theresa
lgtm - still need OWNERS approval.
4 years, 7 months ago (2016-05-24 01:23:45 UTC) #5
Finnur
dfalcantara@ for OWNERS
4 years, 7 months ago (2016-05-25 19:44:03 UTC) #7
gone
OWNERS lgtm.
4 years, 7 months ago (2016-05-25 20:23:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991263002/20001
4 years, 7 months ago (2016-05-25 20:49:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:30:20 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:32:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa39cd5f1a36659f95c7eb9c532d97f38536db21
Cr-Commit-Position: refs/heads/master@{#396011}

Powered by Google App Engine
This is Rietveld 408576698