Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1991253002: [heap] Bundle platform-specific constants for CodeRange (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Bundle platform-specific constants for CodeRange - Removing null checks as we always have the CodeRange object (it might be invalid, but it's there) - Account for reserved area (Win64) in SetUp so we the caller doesn't need to be aware of it R=ulan@chromium.org Committed: https://crrev.com/b114df1d4c3213b706d6b9c14a575921b0c7bb1a Cr-Commit-Position: refs/heads/master@{#36377}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -68 lines) Patch
M src/factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/globals.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 3 chunks +20 lines, -20 lines 0 comments Download
M src/heap/spaces.cc View 1 2 7 chunks +20 lines, -25 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 2 3 3 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
Michael Lippautz
ptal
4 years, 7 months ago (2016-05-19 15:11:11 UTC) #10
ulan
lgtm
4 years, 7 months ago (2016-05-19 15:19:18 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991253002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991253002/100001
4 years, 7 months ago (2016-05-19 15:20:25 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/7544)
4 years, 7 months ago (2016-05-19 15:29:00 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991253002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991253002/120001
4 years, 7 months ago (2016-05-19 15:45:20 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/1965) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-19 16:13:08 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991253002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991253002/140001
4 years, 7 months ago (2016-05-19 16:55:19 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/1915) v8_linux64_asan_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-19 17:18:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991253002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991253002/180001
4 years, 7 months ago (2016-05-19 17:20:57 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:180001)
4 years, 7 months ago (2016-05-19 17:54:06 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:54:53 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b114df1d4c3213b706d6b9c14a575921b0c7bb1a
Cr-Commit-Position: refs/heads/master@{#36377}

Powered by Google App Engine
This is Rietveld 408576698