Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1991233002: [Android] Disable death check in BindingCallbackTest.DeleteCallbackBeforeBindingDeathTest. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable death check in BindingCallbackTest.DeleteCallbackBeforeBindingDeathTest. The Android bot this previously ran on, Android GN, did release builds without DCHECK_ALWAYS_ON, so the death check was being skipped anyway. BUG=610839 Committed: https://crrev.com/59eabd3c7b1ea533decb267a4f06785124e0208d Cr-Commit-Position: refs/heads/master@{#394770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/public/cpp/bindings/tests/binding_callback_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbudorick
4 years, 7 months ago (2016-05-19 13:59:32 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-19 14:22:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991233002/1
4 years, 7 months ago (2016-05-19 14:25:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 15:08:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 15:09:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59eabd3c7b1ea533decb267a4f06785124e0208d
Cr-Commit-Position: refs/heads/master@{#394770}

Powered by Google App Engine
This is Rietveld 408576698