Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 19912002: [SystemInfo API] Rename systemInfo Memory API. (Closed)

Created:
7 years, 5 months ago by Haojian Wu
Modified:
7 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, felt, jar (doing other things), asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[SystemInfo API] Rename systemInfo Memory API. Rename from "systemInfo.memory.get" to "system.memory.getInfo". This is a reland commit of issue 18863014(https://codereview.chromium.org/1886314) There is nothing wrong of the previous patch, so this commit is just a copy. The previous patch got a bad revert since there was a bug on Mac buildbot before. BUG=252994 TEST=update system.memory API browser_tests and pass through Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213127

Patch Set 1 #

Patch Set 2 : Update commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -306 lines) Patch
M chrome/browser/extensions/activity_log/api_name_constants.h View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/extensions/api/system_info_memory/memory_info_provider.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/memory_info_provider.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_api.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_api.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc View 1 chunk +0 lines, -59 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/memory_info_provider.h View 2 chunks +7 lines, -9 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/memory_info_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/system_memory_api.h View 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/system_memory_api.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + chrome/browser/extensions/api/system_memory/system_memory_apitest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/system_info_memory.idl View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/common/extensions/api/system_memory.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/redirects.json View 1 chunk +2 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/systemInfo_memory.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/system_memory.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/extensions/redirects.json View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/extensions/system_memory.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/system/memory/manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/api_test/system/memory/test_memory_api.js View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/api_test/systeminfo/memory/test_memory_api.js View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Haojian Wu
A new copied CL from the previous CL https://codereview.chromium.org/18863014/. The previous CL has been reverted(see ...
7 years, 5 months ago (2013-07-21 15:29:18 UTC) #1
Hongbo Min
On 2013/07/21 15:29:18, Haojian Wu wrote: > A new copied CL from the previous CL ...
7 years, 5 months ago (2013-07-22 01:40:21 UTC) #2
Haojian Wu
On 2013/07/22 01:40:21, Hongbo Min wrote: > On 2013/07/21 15:29:18, Haojian Wu wrote: > > ...
7 years, 5 months ago (2013-07-22 13:39:10 UTC) #3
Hongbo Min
lgtm
7 years, 5 months ago (2013-07-22 13:48:34 UTC) #4
not at google - send to devlin
Can the sheriff revert the bad revert? A separate CL loses history. But whatever, lgtm, ...
7 years, 5 months ago (2013-07-22 14:41:08 UTC) #5
Haojian Wu
On 2013/07/22 14:41:08, kalman wrote: > Can the sheriff revert the bad revert? A separate ...
7 years, 5 months ago (2013-07-22 15:28:38 UTC) #6
Ilya Sherman
LGTM
7 years, 5 months ago (2013-07-23 00:21:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/19912002/7001
7 years, 5 months ago (2013-07-23 00:54:10 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=151494
7 years, 5 months ago (2013-07-23 02:52:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/19912002/7001
7 years, 5 months ago (2013-07-23 09:20:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=151132
7 years, 5 months ago (2013-07-23 10:10:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Hokein.Wu@gmail.com/19912002/7001
7 years, 5 months ago (2013-07-23 15:07:11 UTC) #12
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 15:35:41 UTC) #13
Message was sent while issue was closed.
Change committed as 213127

Powered by Google App Engine
This is Rietveld 408576698