Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: src/objects.cc

Issue 1991173002: [keys] Don't omit write barrier after std::sort (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixing isolate ref Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index cc11130c3862ece8f17ee2d9dff807d69da15533..67c5e5f2d3b4b7c82172b3b930df74fb10815d04 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -17134,6 +17134,8 @@ void Dictionary<Derived, Shape, Key>::CollectKeysTo(
EnumIndexComparator<Derived> cmp(static_cast<Derived*>(raw_dict));
Smi** start = reinterpret_cast<Smi**>(array->GetFirstElementAddress());
std::sort(start, start + array_size, cmp);
+ FIXED_ARRAY_ELEMENTS_WRITE_BARRIER(keys->isolate()->heap(), *array, 0,
+ array->length());
}
for (int i = 0; i < array_size; i++) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698