Cleanup unused fgas/ code.

xfa/fgas/crt/fgas_utils.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FGAS_CRT_FGAS_UTILS_H_
 #define XFA_FGAS_CRT_FGAS_UTILS_H_
 
 #include "core/fxcrt/include/fx_coordinates.h"
@@ skipping 62 matching lines @@
                int32_t iCount = -1) {
     return CFX_BaseArray::Copy(src, iStart, iCount);
   }
   int32_t RemoveLast(int32_t iCount = -1) {
     return CFX_BaseArray::RemoveLast(iCount);
   }
   void RemoveAll(FX_BOOL bLeaveMemory = FALSE) {
     CFX_BaseArray::RemoveAll(bLeaveMemory);
   }
 };
-typedef CFX_BaseArrayTemplate<void*> CFDE_PtrArray;
 typedef CFX_BaseArrayTemplate<uint32_t> CFDE_DWordArray;

[Tom Sepez, 2016/05/19 16:20:53]

This is only used in one place in fde_csscache.h, so we can remove the typedef
and just use the full name CFX_BaseArrayTemplate<uint32_t> there instead.

-typedef CFX_BaseArrayTemplate<uint16_t> CFDE_WordArray;
 
 template <class baseType>
 class CFX_ObjectBaseArrayTemplate : public CFX_BaseArray {
  public:
   CFX_ObjectBaseArrayTemplate(int32_t iGrowSize = 100)
       : CFX_BaseArray(iGrowSize, sizeof(baseType)) {}
   ~CFX_ObjectBaseArrayTemplate() { RemoveAll(FALSE); }
   int32_t GetSize() const { return CFX_BaseArray::GetSize(); }
   int32_t GetBlockSize() const { return CFX_BaseArray::GetBlockSize(); }
   int32_t Add(const baseType& element) {
@@ skipping 174 matching lines @@
                int32_t iCount = -1) {
     return CFX_BaseMassArray::Copy(src, iStart, iCount);
   }
   int32_t RemoveLast(int32_t iCount = -1) {
     return CFX_BaseMassArray::RemoveLast(iCount);
   }
   void RemoveAll(FX_BOOL bLeaveMemory = FALSE) {
     CFX_BaseMassArray::RemoveAll(bLeaveMemory);
   }
 };
-typedef CFX_MassArrayTemplate<void*> CFX_PtrMassArray;
-typedef CFX_MassArrayTemplate<int32_t> CFX_Int32MassArray;
-typedef CFX_MassArrayTemplate<uint32_t> CFX_DWordMassArray;
-typedef CFX_MassArrayTemplate<uint16_t> CFX_WordMassArray;
 typedef CFX_MassArrayTemplate<CFX_Rect> CFX_RectMassArray;

[Tom Sepez, 2016/05/19 16:20:53]

Ditto here, two usages, remove typedef and use full type in those places.

-typedef CFX_MassArrayTemplate<CFX_RectF> CFX_RectFMassArray;
 
 template <class baseType>
 class CFX_ObjectMassArrayTemplate : public CFX_BaseMassArray {
  public:
   CFX_ObjectMassArrayTemplate(int32_t iChunkSize = 100)
       : CFX_BaseMassArray(iChunkSize, sizeof(baseType)) {}
   ~CFX_ObjectMassArrayTemplate() { RemoveAll(FALSE); }
   int32_t GetSize() const { return CFX_BaseMassArray::GetSize(); }
   int32_t Add(const baseType& element) {
     int32_t index = CFX_BaseMassArray::GetSize();
@@ skipping 191 matching lines @@
     }
     RemoveAll(TRUE);
     for (int32_t i = iStart; i < iEnd; i++) {
       Push(*src.GetAt(i));
     }
     return CFX_BaseStack::GetSize();
   }
 };
 
 #endif  // XFA_FGAS_CRT_FGAS_UTILS_H_