Cleanup unused fgas/ code.

Cleanup unused fgas/ code.

Purely code removal.

Committed: https://pdfium.googlesource.com/pdfium/+/bc9164115e8aeefcc06f5bf08684a4733b25e085

[dsinclair, 2016-05-19 15:05:56]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-19 15:05:56]

PTAL.

[Tom Sepez, 2016-05-19 16:20:53]

LGTM.  Red code is best code.  Also, some suggestions for followup:

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/crt/fgas_utils.h
File xfa/fgas/crt/fgas_utils.h (right):

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/crt/fgas_utils.h#n...
xfa/fgas/crt/fgas_utils.h:83: typedef CFX_BaseArrayTemplate<uint32_t>
CFDE_DWordArray;
This is only used in one place in fde_csscache.h, so we can remove the typedef
and just use the full name CFX_BaseArrayTemplate<uint32_t> there instead.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/crt/fgas_utils.h#n...
xfa/fgas/crt/fgas_utils.h:278: typedef CFX_MassArrayTemplate<CFX_Rect>
CFX_RectMassArray;
Ditto here, two usages, remove typedef and use full type in those places.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
File xfa/fgas/font/fgas_stdfontmgr.h (right):

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:145: typedef CFX_MapPtrTemplate<uint32_t,
IFX_FileAccess*> CFX_HashFileMap;
ditto: one usage.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:146: typedef CFX_MapPtrTemplate<uint32_t,
IFX_Font*> CFX_HashFontMap;
one usage.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:147: typedef CFX_MapPtrTemplate<uint32_t,
CFX_FontDescriptorInfos*>
one usage.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:149: typedef CFX_MapPtrTemplate<uint32_t,
CFX_ArrayTemplate<IFX_Font*>*>
once

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:151: typedef CFX_MapPtrTemplate<FX_WCHAR,
IFX_Font*> CFX_UnicodeFontMap;
1.

https://codereview.chromium.org/1991143003/diff/1/xfa/fgas/font/fgas_stdfontm...
xfa/fgas/font/fgas_stdfontmgr.h:152: typedef CFX_MapPtrTemplate<IFX_Font*,
IFX_FileRead*> CFX_FonStreamtMap;
yup.

[dsinclair, 2016-05-19 17:51:31]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-19 17:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991143003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991143003/1

[commit-bot: I haz the power, 2016-05-19 17:52:08]

Description was changed from

==========
Cleanup unused fgas/ code.

Purely code removal.
==========

to

==========
Cleanup unused fgas/ code.

Purely code removal.

Committed:
https://pdfium.googlesource.com/pdfium/+/bc9164115e8aeefcc06f5bf08684a4733b25...
==========

[commit-bot: I haz the power, 2016-05-19 17:52:09]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc9164115e8aeefcc06f5bf08684a4733b25...