Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: src/compiler/wasm-compiler.h

Issue 1991143002: Convert SIMD wasm ops to runtime function calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Bill's review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/wasm-compiler.h
diff --git a/src/compiler/wasm-compiler.h b/src/compiler/wasm-compiler.h
index 93c2ae91d10168e573ac8f0178bb261e74d5ca8e..6c5e34c7d3b834ea19a53e0d1dbbf6f61548f8b2 100644
--- a/src/compiler/wasm-compiler.h
+++ b/src/compiler/wasm-compiler.h
@@ -133,6 +133,10 @@ class WasmGraphBuilder {
Node* FromJS(Node* node, Node* context, wasm::LocalType type);
Node* Invert(Node* node);
Node* FunctionTable();
+ Node* BuildChangeInt32ToTagged(Node* value);
+ Node* BuildChangeTaggedToInt32(Node* value);
+ Node* BuildChangeFloat64ToTagged(Node* value);
+ Node* BuildChangeTaggedToFloat64(Node* value);
//-----------------------------------------------------------------------
// Operations that concern the linear memory.
@@ -162,6 +166,13 @@ class WasmGraphBuilder {
void SetSourcePosition(Node* node, wasm::WasmCodePosition position);
+ //-----------------------------------------------------------------------
+ // SIMD operations.
+ //-----------------------------------------------------------------------
+ Node* DefaultS128Value();
+ void set_is_simd_function(bool simd) { this->is_simd_function_ = simd; }
titzer 2016/05/19 09:43:27 I think this should be "has simd ops" and should b
gdeepti 2016/07/01 22:24:48 Changed to HasSimdOps, and is now only set interna
+ bool is_simd_function() { return is_simd_function_; }
+
private:
static const int kDefaultBufferSize = 16;
friend class WasmTrapHelper;
@@ -180,6 +191,7 @@ class WasmGraphBuilder {
WasmTrapHelper* trap_;
wasm::FunctionSig* function_signature_;
+ bool is_simd_function_;
SetOncePointer<const Operator> allocate_heap_number_operator_;
compiler::SourcePositionTable* source_position_table_ = nullptr;
@@ -277,9 +289,6 @@ class WasmGraphBuilder {
Node* BuildJavaScriptToNumber(Node* node, Node* context, Node* effect,
Node* control);
- Node* BuildChangeInt32ToTagged(Node* value);
- Node* BuildChangeFloat64ToTagged(Node* value);
- Node* BuildChangeTaggedToFloat64(Node* value);
Node* BuildChangeInt32ToSmi(Node* value);
Node* BuildChangeSmiToInt32(Node* value);

Powered by Google App Engine
This is Rietveld 408576698