Fix a potential nullptr deref in CFX_MapPtrToPtr.

Fix a potential nullptr deref in CFX_MapPtrToPtr.

And also in CFX_PtrList.

BUG=596528
Committed: https://pdfium.googlesource.com/pdfium/+/db9e49889d4129bbe96abdbce7dc3662e97a9df8

[Lei Zhang, 2016-05-19 06:41:11]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-05-19 06:41:11]

The weird thing is that the original code does not crash in my Clang built
pdfium_test binary.

[Tom Sepez, 2016-05-19 17:02:01]

lgtm

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cpp
File core/fxcrt/fx_basic_list.cpp (right):

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:78: m_pNodeHead = m_pNodeTail = m_pNodeFree = NULL;
nit: one per pline.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:79: if (m_pBlocks)
Ah, idempotency.

Nit: As long as we're going to test it, we can conditionalize the NULL
assignment by this if statement.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:81: m_pBlocks = NULL;
nit: nullptr, also above.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_maps.cpp
File core/fxcrt/fx_basic_maps.cpp (right):

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_maps.cp...
core/fxcrt/fx_basic_maps.cpp:24: if (m_pBlocks)
ditto: conditionalize NULL assign, nullptrs.

[Lei Zhang, 2016-05-19 20:48:50]

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cpp
File core/fxcrt/fx_basic_list.cpp (right):

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:78: m_pNodeHead = m_pNodeTail = m_pNodeFree = NULL;
On 2016/05/19 17:02:01, Tom Sepez wrote:
> nit: one per pline.

Done.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:79: if (m_pBlocks)
On 2016/05/19 17:02:01, Tom Sepez wrote:
> Ah, idempotency.
> 
> Nit: As long as we're going to test it, we can conditionalize the NULL
> assignment by this if statement.

Done.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_list.cp...
core/fxcrt/fx_basic_list.cpp:81: m_pBlocks = NULL;
On 2016/05/19 17:02:01, Tom Sepez wrote:
> nit: nullptr, also above.

Done.

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_maps.cpp
File core/fxcrt/fx_basic_maps.cpp (right):

https://codereview.chromium.org/1991123002/diff/1/core/fxcrt/fx_basic_maps.cp...
core/fxcrt/fx_basic_maps.cpp:24: if (m_pBlocks)
On 2016/05/19 17:02:01, Tom Sepez wrote:
> ditto: conditionalize NULL assign, nullptrs.

Done.

[Tom Sepez, 2016-05-19 22:34:48]

still LGTM

[Lei Zhang, 2016-05-19 22:36:10]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-19 22:36:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991123002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991123002/40001

[commit-bot: I haz the power, 2016-05-19 22:36:39]

Description was changed from

==========
Fix a potential nullptr deref in CFX_MapPtrToPtr.

And also in CFX_PtrList.

BUG=596528
==========

to

==========
Fix a potential nullptr deref in CFX_MapPtrToPtr.

And also in CFX_PtrList.

BUG=596528

Committed:
https://pdfium.googlesource.com/pdfium/+/db9e49889d4129bbe96abdbce7dc3662e97a...
==========

[commit-bot: I haz the power, 2016-05-19 22:36:39]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/db9e49889d4129bbe96abdbce7dc3662e97a...