extensions/browser/guest_view/web_view/web_view_find_helper.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_find_helper.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

index c7339e1eda9fe665602df675838064614deb8cb9..82a335f8c2f0d61c3bc55afee64118b68d901d35 100644

--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc

@@ -282,7 +282,7 @@ void WebViewFindHelper::FindInfo::SendResponse(bool canceled) {

results.SetBoolean(webview::kFindCanceled, canceled);

// Call the callback.

- find_function_->SetResult(results.DeepCopy());

+ find_function_->SetResult(results.CreateDeepCopy());

find_function_->SendResponse(true);

}