Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2110)

Unified Diff: extensions/browser/extension_function.h

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index 0bf876410a02f18583d060e3a1d529db621fa8a5..3428ee7ddc0fdfbb96639e3535d75e27abc61bf3 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -201,12 +201,11 @@ class ExtensionFunction
virtual void OnQuotaExceeded(const std::string& violation_error);
// Specifies the raw arguments to the function, as a JSON value.
+ // TODO(dcheng): This should take a const ref.
virtual void SetArgs(const base::ListValue* args);
// Sets a single Value as the results of the function.
void SetResult(std::unique_ptr<base::Value> result);
- // As above, but deprecated. TODO(estade): remove.
- void SetResult(base::Value* result);
// Sets multiple Values as the results of the function.
void SetResultList(std::unique_ptr<base::ListValue> results);

Powered by Google App Engine
This is Rietveld 408576698