Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2307)

Unified Diff: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
diff --git a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
index cad4f8b9a1d3a8e3667df1712f8bd5a9af13f84e..05c14d8ecf6bfa1ef936e3a1f4edbbee1b309b8b 100644
--- a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
+++ b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc
@@ -4,6 +4,9 @@
#include "extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h"
+#include <memory>
+#include <utility>
+
#include "base/lazy_instance.h"
#include "base/strings/string16.h"
#include "extensions/browser/api/extensions_api_client.h"
@@ -113,9 +116,9 @@ bool VirtualKeyboardPrivateKeyboardLoadedFunction::RunSync() {
bool VirtualKeyboardPrivateGetKeyboardConfigFunction::RunSync() {
VirtualKeyboardDelegate* delegate = GetDelegate(this);
if (delegate) {
- base::DictionaryValue* results = new base::DictionaryValue();
- if (delegate->GetKeyboardConfig(results)) {
- SetResult(results);
+ std::unique_ptr<base::DictionaryValue> results(new base::DictionaryValue());
+ if (delegate->GetKeyboardConfig(results.get())) {
+ SetResult(std::move(results));
return true;
}
}

Powered by Google App Engine
This is Rietveld 408576698