extensions/browser/api/system_cpu/system_cpu_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_cpu/system_cpu_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/system_cpu/system_cpu_api.cc

diff --git a/extensions/browser/api/system_cpu/system_cpu_api.cc b/extensions/browser/api/system_cpu/system_cpu_api.cc

index 5cfe69b0ff4cd6b99bd37db9b22fd0e7e49eef5b..2e252388a19c97cb0cb9259020f098c554f87d0d 100644

--- a/extensions/browser/api/system_cpu/system_cpu_api.cc

+++ b/extensions/browser/api/system_cpu/system_cpu_api.cc

@@ -25,7 +25,7 @@ bool SystemCpuGetInfoFunction::RunAsync() {

void SystemCpuGetInfoFunction::OnGetCpuInfoCompleted(bool success) {

if (success)

- SetResult(CpuInfoProvider::Get()->cpu_info().ToValue().release());

+ SetResult(CpuInfoProvider::Get()->cpu_info().ToValue());

else

SetError("Error occurred when querying cpu information.");

SendResponse(success);