Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: extensions/browser/api/serial/serial_apitest.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/serial/serial_apitest.cc
diff --git a/extensions/browser/api/serial/serial_apitest.cc b/extensions/browser/api/serial/serial_apitest.cc
index 40ee4e919f0ecab13aa5be3385b651d50cb9b6f5..0e1ec67916268bfc5b58ee000b127388dd8ef7a0 100644
--- a/extensions/browser/api/serial/serial_apitest.cc
+++ b/extensions/browser/api/serial/serial_apitest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
#include <string>
#include <utility>
@@ -29,14 +30,14 @@ namespace {
class FakeSerialGetDevicesFunction : public AsyncExtensionFunction {
public:
bool RunAsync() override {
- base::ListValue* devices = new base::ListValue();
+ std::unique_ptr<base::ListValue> devices(new base::ListValue());
base::DictionaryValue* device0 = new base::DictionaryValue();
device0->SetString("path", "/dev/fakeserial");
base::DictionaryValue* device1 = new base::DictionaryValue();
device1->SetString("path", "\\\\COM800\\");
devices->Append(device0);
devices->Append(device1);
- SetResult(devices);
+ SetResult(std::move(devices));
SendResponse(true);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698