extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_tab_util.cc ('K') | « extensions/browser/api/cast_channel/cast_channel_api.cc ('k') | extensions/browser/api/guest_view/guest_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

diff --git a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

index 53e31849d110e0edca366161845cac705438238b..727824f10c047bf839721324c61fd7269a01b3ad 100644

--- a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

+++ b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

@@ -6,6 +6,7 @@

#include <utility>

+#include "base/memory/ptr_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "components/crx_file/id_util.h"

@@ -63,7 +64,7 @@ bool ExtensionViewInternalLoadSrcFunction::RunAsyncSafe(

has_load_succeeded = guest->NavigateGuest(src, true /* force_navigation */);

// Return whether load is successful.

- SetResult(new base::FundamentalValue(has_load_succeeded));

+ SetResult(base::MakeUnique<base::FundamentalValue>(has_load_succeeded));

SendResponse(true);

return true;

}