Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: chrome/browser/extensions/api/tabs/app_window_controller.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/app_window_controller.cc
diff --git a/chrome/browser/extensions/api/tabs/app_window_controller.cc b/chrome/browser/extensions/api/tabs/app_window_controller.cc
index 3e708e4f49447303aeeeb1b89a7dff03a61b5f33..38e717924b0f2ffa4184b6be37bc54370dd61d3e 100644
--- a/chrome/browser/extensions/api/tabs/app_window_controller.cc
+++ b/chrome/browser/extensions/api/tabs/app_window_controller.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/extensions/api/tabs/app_window_controller.h"
+#include <memory>
#include <utility>
#include "base/strings/utf_string_conversions.h"
@@ -45,9 +46,10 @@ std::string AppWindowController::GetWindowTypeText() const {
return tabs_constants::kWindowTypeValueApp;
}
-base::DictionaryValue* AppWindowController::CreateWindowValueWithTabs(
+std::unique_ptr<base::DictionaryValue>
+AppWindowController::CreateWindowValueWithTabs(
const Extension* extension) const {
- base::DictionaryValue* result = CreateWindowValue();
+ std::unique_ptr<base::DictionaryValue> result = CreateWindowValue();
base::DictionaryValue* tab_value = CreateTabValue(extension, 0);
if (!tab_value)

Powered by Google App Engine
This is Rietveld 408576698