Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
index 64d66a0b65be11a7b04b7e00fa1e228f89cc4e92..b767c1bad7aec6c704fac84b57389f30112cef21 100644
--- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
+++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
@@ -427,7 +427,7 @@ void LogPrivateGetHistoricalFunction::OnSystemLogsLoaded(
CollectLogInfo(filter_handler_.get(), sys_info.get(), &result.data);
api::log_private::Filter::Populate(
*((filter_handler_->GetFilter())->ToValue()), &result.filter);
- SetResult(result.ToValue().release());
+ SetResult(result.ToValue());
SendResponse(true);
}
@@ -540,7 +540,7 @@ void LogPrivateDumpLogsFunction::OnStoreLogsCompleted(
entry_list->Append(entry);
response->Set("entries", entry_list);
response->SetBoolean("multiple", false);
- SetResult(response.release());
+ SetResult(std::move(response));
SendResponse(succeeded);
}

Powered by Google App Engine
This is Rietveld 408576698