Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/extensions/api/idltest/idltest_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/idltest/idltest_api.cc
diff --git a/chrome/browser/extensions/api/idltest/idltest_api.cc b/chrome/browser/extensions/api/idltest/idltest_api.cc
index 51f749d41d1a5baf2fa97da4a65e79c9236493cb..bb3685a8bec20467e04bf1894d4e403170da55f6 100644
--- a/chrome/browser/extensions/api/idltest/idltest_api.cc
+++ b/chrome/browser/extensions/api/idltest/idltest_api.cc
@@ -6,14 +6,18 @@
#include <stddef.h>
+#include <memory>
+
+#include "base/memory/ptr_util.h"
#include "base/values.h"
using base::BinaryValue;
namespace {
-base::ListValue* CopyBinaryValueToIntegerList(const BinaryValue* input) {
- base::ListValue* output = new base::ListValue();
+std::unique_ptr<base::ListValue> CopyBinaryValueToIntegerList(
+ const BinaryValue* input) {
+ std::unique_ptr<base::ListValue> output(new base::ListValue());
const char* input_buffer = input->GetBuffer();
for (size_t i = 0; i < input->GetSize(); i++) {
output->Append(new base::FundamentalValue(input_buffer[i]));
@@ -41,6 +45,6 @@ bool IdltestGetArrayBufferFunction::RunSync() {
std::string hello = "hello world";
BinaryValue* output =
BinaryValue::CreateWithCopiedBuffer(hello.c_str(), hello.size());
- SetResult(output);
+ SetResult(base::WrapUnique(output));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698