chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/downloads/downloads_api.cc ('K') | « chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc

index 1b386e3cdbaa1ba19c95def079047ef90d9c5b22..f212226b785a14822c4b5a0fcda20e708370b1f0 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling_private_api.cc

@@ -18,7 +18,7 @@ bool ExperienceSamplingPrivateGetBrowserInfoFunction::RunAsync() {

base::FieldTrialList::StatesToString(&field_trials);

info.variations = field_trials;

- SetResult(info.ToValue().release());

+ SetResult(info.ToValue());

SendResponse(true /* success */);

return true;

}