Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/dial/dial_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/dial/dial_api.cc
diff --git a/chrome/browser/extensions/api/dial/dial_api.cc b/chrome/browser/extensions/api/dial/dial_api.cc
index ed8ad5d1fa62ef2cc54873201ecb0fcbd0dc95c1..30eac215513feacfbd8645957af81c223abdd505 100644
--- a/chrome/browser/extensions/api/dial/dial_api.cc
+++ b/chrome/browser/extensions/api/dial/dial_api.cc
@@ -8,6 +8,7 @@
#include <utility>
#include <vector>
+#include "base/memory/ptr_util.h"
#include "base/time/time.h"
#include "chrome/browser/extensions/api/dial/dial_api_factory.h"
#include "chrome/browser/profiles/profile.h"
@@ -166,7 +167,7 @@ void DialDiscoverNowFunction::Work() {
bool DialDiscoverNowFunction::Respond() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- SetResult(new base::FundamentalValue(result_));
+ SetResult(base::MakeUnique<base::FundamentalValue>(result_));
return true;
}
« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698