chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc ('k') | chrome/browser/extensions/api/browsing_data/browsing_data_api.cc » ('j') | chrome/browser/extensions/api/content_settings/content_settings_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

index ad56f81e9e7017f24e931797c5447a8044671eb8..73d1bdbf342f3c0dda2292decc6ccfcd115fa5e5 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_display_private_api.cc

@@ -151,8 +151,7 @@ bool BrailleDisplayPrivateGetDisplayStateFunction::Prepare() {

}

void BrailleDisplayPrivateGetDisplayStateFunction::Work() {

- SetResult(

- BrailleController::GetInstance()->GetDisplayState()->ToValue().release());

+ SetResult(BrailleController::GetInstance()->GetDisplayState()->ToValue());

}

bool BrailleDisplayPrivateGetDisplayStateFunction::Respond() {