Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
diff --git a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
index 99b041aa5749bf8bcc80b5dd166bfd7b0e3c51f6..ad8a500fcea9d99a7febb1d3a3458f5946f0502d 100644
--- a/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
+++ b/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
@@ -4,6 +4,9 @@
#include "chrome/browser/extensions/api/autotest_private/autotest_private_api.h"
+#include <memory>
+#include <utility>
+
#include "base/lazy_instance.h"
#include "base/strings/string_number_conversions.h"
#include "build/build_config.h"
@@ -98,7 +101,7 @@ bool AutotestPrivateShutdownFunction::RunSync() {
bool AutotestPrivateLoginStatusFunction::RunSync() {
DVLOG(1) << "AutotestPrivateLoginStatusFunction";
- base::DictionaryValue* result(new base::DictionaryValue);
+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
#if defined(OS_CHROMEOS)
const user_manager::UserManager* user_manager =
user_manager::UserManager::Get();
@@ -138,7 +141,7 @@ bool AutotestPrivateLoginStatusFunction::RunSync() {
}
#endif
- SetResult(result);
+ SetResult(std::move(result));
return true;
}
@@ -205,9 +208,10 @@ bool AutotestPrivateGetExtensionsInfoFunction::RunSync() {
extensions_values->Append(extension_value);
}
- base::DictionaryValue* return_value(new base::DictionaryValue);
+ std::unique_ptr<base::DictionaryValue> return_value(
+ new base::DictionaryValue);
return_value->Set("extensions", extensions_values);
- SetResult(return_value);
+ SetResult(std::move(return_value));
return true;
}
@@ -346,9 +350,9 @@ std::string AutotestPrivateGetVisibleNotificationsFunction::ConvertToString(
bool AutotestPrivateGetVisibleNotificationsFunction::RunSync() {
DVLOG(1) << "AutotestPrivateGetVisibleNotificationsFunction";
- base::ListValue* values = new base::ListValue;
+ std::unique_ptr<base::ListValue> values(new base::ListValue);
#if defined(OS_CHROMEOS)
- for (auto notification :
+ for (auto* notification :
message_center::MessageCenter::Get()->GetVisibleNotifications()) {
base::DictionaryValue* result(new base::DictionaryValue);
result->SetString("id", notification->id());
@@ -361,7 +365,7 @@ bool AutotestPrivateGetVisibleNotificationsFunction::RunSync() {
}
#endif
- SetResult(values);
+ SetResult(std::move(values));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698