chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IWYU Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc » ('j') | chrome/browser/extensions/api/content_settings/content_settings_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

index 708b3e74e4bf6740a530a24710d54973064a7f35..2943bbff1f4aa3af1d072578fcf78287cdcfd73e 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc

@@ -8,6 +8,7 @@

#include "base/files/file_util.h"

#include "base/format_macros.h"

+#include "base/memory/ptr_util.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/chromeos/drive/file_system_util.h"

#include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h"

@@ -154,7 +155,7 @@ void FileManagerPrivateAddMountFunction::RunAfterMarkCacheFileAsMounted(

}

// Pass back the actual source path of the mount point.

- SetResult(new base::StringValue(file_path.AsUTF8Unsafe()));

+ SetResult(base::MakeUnique<base::StringValue>(file_path.AsUTF8Unsafe()));

SendResponse(true);

// MountPath() takes a std::string.