Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1991073002: Update ServiceWorker page load histograms to log immediately. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
Reviewers:
kinuko, rkaplow, horo
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ServiceWorker page load histograms to log immediately. BUG=612576 Committed: https://crrev.com/ddecf0e6d669cf4a303e32f128958f6469e885f1 Cr-Commit-Position: refs/heads/master@{#394804}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -34 lines) Patch
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc View 1 1 chunk +43 lines, -28 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Bryan McQuade
PTAL.
4 years, 7 months ago (2016-05-19 01:18:57 UTC) #2
kinuko
lgtm % nits https://codereview.chromium.org/1991073002/diff/1/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h (right): https://codereview.chromium.org/1991073002/diff/1/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h#newcode27 chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h:27: static bool IsServiceWorkerControlled( This can probably ...
4 years, 7 months ago (2016-05-19 02:24:10 UTC) #3
horo
lgtm
4 years, 7 months ago (2016-05-19 02:29:07 UTC) #4
Bryan McQuade
rkaplow, PTAL for histograms.xml. Thanks!
4 years, 7 months ago (2016-05-19 13:25:49 UTC) #6
Bryan McQuade
https://codereview.chromium.org/1991073002/diff/1/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h File chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h (right): https://codereview.chromium.org/1991073002/diff/1/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h#newcode27 chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h:27: static bool IsServiceWorkerControlled( On 2016/05/19 at 02:24:10, kinuko wrote: ...
4 years, 7 months ago (2016-05-19 13:29:08 UTC) #7
rkaplow
lgtm
4 years, 7 months ago (2016-05-19 17:18:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991073002/20001
4 years, 7 months ago (2016-05-19 17:21:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 17:25:49 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:27:15 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ddecf0e6d669cf4a303e32f128958f6469e885f1
Cr-Commit-Position: refs/heads/master@{#394804}

Powered by Google App Engine
This is Rietveld 408576698