Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ct/go/worker_scripts/capture_skps_from_pdfs/main.go

Issue 1991043005: Add support for parallel runs (Closed) Base URL: https://skia.googlesource.com/buildbot@ct-8-chromium_analysis
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ct/go/worker_scripts/build_repo/main.go ('k') | ct/go/worker_scripts/run_chromium_perf/main.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ct/go/worker_scripts/capture_skps_from_pdfs/main.go
diff --git a/ct/go/worker_scripts/capture_skps_from_pdfs/main.go b/ct/go/worker_scripts/capture_skps_from_pdfs/main.go
index 206d1e61d75da33cf1e59cd4f93604b035bfd240..620625a4d5f5f27c4a60929498b6113c62b33ebe 100644
--- a/ct/go/worker_scripts/capture_skps_from_pdfs/main.go
+++ b/ct/go/worker_scripts/capture_skps_from_pdfs/main.go
@@ -35,7 +35,7 @@ var (
startRange = flag.Int("start_range", 1, "The number this worker will capture SKPs from.")
num = flag.Int("num", 100, "The total number of SKPs to capture starting from the start_range.")
pagesetType = flag.String("pageset_type", util.PAGESET_TYPE_PDF_1m, "The type of pagesets to use for this run. Eg: PDF1m.")
- chromiumBuild = flag.String("chromium_build", "", "The specified chromium build. This value is used to find the pdfium_test binary from Google Storage and while uploading the PDFs and SKPs to Google Storage.")
+ chromiumBuild = flag.String("chromium_build", "", "The specified chromium build. This value is used while uploading the PDFs and SKPs to Google Storage.")
runID = flag.String("run_id", "", "The unique run id (typically requester + timestamp).")
targetPlatform = flag.String("target_platform", util.PLATFORM_LINUX, "The platform the benchmark will run on (Android / Linux).")
)
@@ -93,7 +93,7 @@ func main() {
// TODO(rmistry): Uncomment when ready to capture SKPs.
//// Copy over the pdfium_test binary to this slave.
//pdfiumLocalPath := filepath.Join(os.TempDir(), util.BINARY_PDFIUM_TEST)
- //pdfiumRemotePath := filepath.Join(util.BinariesDir, *chromiumBuild, util.BINARY_PDFIUM_TEST)
+ //pdfiumRemotePath := filepath.Join(util.BinariesDir, *runID, util.BINARY_PDFIUM_TEST)
//respBody, err := gs.GetRemoteFileContents(pdfiumRemotePath)
//if err != nil {
// glog.Errorf("Could not fetch %s: %s", pdfiumRemotePath, err)
« no previous file with comments | « ct/go/worker_scripts/build_repo/main.go ('k') | ct/go/worker_scripts/run_chromium_perf/main.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698