Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: ct/go/master_scripts/run_chromium_analysis_on_workers/main.go

Issue 1991043005: Add support for parallel runs (Closed) Base URL: https://skia.googlesource.com/buildbot@ct-8-chromium_analysis
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ct/go/master_scripts/run_chromium_analysis_on_workers/main.go
diff --git a/ct/go/master_scripts/run_chromium_analysis_on_workers/main.go b/ct/go/master_scripts/run_chromium_analysis_on_workers/main.go
index 123be8ede7f274b6496a162d4bbca8d14f71bdd8..b9f3907a55304284891ccc4be5ebf8b6e68a6bbe 100644
--- a/ct/go/master_scripts/run_chromium_analysis_on_workers/main.go
+++ b/ct/go/master_scripts/run_chromium_analysis_on_workers/main.go
@@ -109,7 +109,7 @@ func main() {
defer updateWebappTask()
defer sendEmail(emailsArr)
// Cleanup dirs after run completes.
- defer skutil.RemoveAll(filepath.Join(util.StorageDir, util.BenchmarkRunsDir))
+ defer skutil.RemoveAll(filepath.Join(util.StorageDir, util.BenchmarkRunsDir, *runID))
// Finish with glog flush and how long the task took.
defer util.TimeTrack(time.Now(), "Running chromium analysis task on workers")
defer glog.Flush()
@@ -147,13 +147,19 @@ func main() {
chromiumPatchLink = util.GS_HTTP_LINK + filepath.Join(util.GSBucketName, remoteOutputDir, chromiumPatchName)
benchmarkPatchLink = util.GS_HTTP_LINK + filepath.Join(util.GSBucketName, remoteOutputDir, benchmarkPatchName)
- // Create the required chromium build.
- chromiumHash, skiaHash, err := util.CreateChromiumBuild(*runID, "Linux", "", "", true, true)
+ //// Create the required chromium build.
+ //chromiumHash, skiaHash, err := util.CreateChromiumBuild(*runID, "Linux", "", "", true, true)
+ //if err != nil {
+ // glog.Errorf("Could not create chromium build: %s", err)
+ // return
+ //}
+ //chromiumBuild := fmt.Sprintf("try-%s-%s-%s-withpatch", chromiumHash, skiaHash, *runID)
+
+ chromiumBuild, err := util.TriggerBuildRepoSwarmingTask("build_chromium", *runID, "chromium", "Linux", []string{}, []string{filepath.Join(remoteOutputDir, chromiumPatchName)}, true, 3*time.Hour, 1*time.Hour)
if err != nil {
- glog.Errorf("Could not create chromium build: %s", err)
+ glog.Errorf("Error encountered when swarming build repo task: %s", err)
return
}
- chromiumBuild := fmt.Sprintf("try-%s-%s-%s-withpatch", chromiumHash, skiaHash, *runID)
// Archive, trigger and collect swarming tasks.
isolateExtraArgs := map[string]string{
« no previous file with comments | « ct/go/master_scripts/capture_skps_on_workers/main.go ('k') | ct/go/master_scripts/run_chromium_perf_on_workers/main.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698