Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1991043003: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros Replace WTF_LOG macros with DVLOG in HTMLSourceElement.cpp. BUG=596522 Committed: https://crrev.com/b713fbf448790f824cf973281e40663b3bc95e67 Cr-Commit-Position: refs/heads/master@{#394788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSourceElement.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Srirama
This is the only file left in core/, i should have added it in the ...
4 years, 7 months ago (2016-05-19 14:35:26 UTC) #3
fs
lgtm
4 years, 7 months ago (2016-05-19 14:41:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991043003/1
4 years, 7 months ago (2016-05-19 14:55:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 16:26:05 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 16:28:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b713fbf448790f824cf973281e40663b3bc95e67
Cr-Commit-Position: refs/heads/master@{#394788}

Powered by Google App Engine
This is Rietveld 408576698