Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1991043002: [DevTools] Set toString for native CommandLineAPI methods in native (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Set toString for native CommandLineAPI methods in native BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea Cr-Commit-Position: refs/heads/master@{#394637}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 2 chunks +27 lines, -16 lines 0 comments Download

Dependent Patchsets:

Issue 1983423002 Patch 80001
Issue 1983423002 Patch 100001

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look!
4 years, 7 months ago (2016-05-19 00:02:09 UTC) #1
dgozman
lgtm
4 years, 7 months ago (2016-05-19 00:19:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991043002/20001
4 years, 7 months ago (2016-05-19 00:19:39 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 02:09:19 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 02:10:27 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5b2e08ec38956ebfb8ccca5a5ebefcddabd2dbea
Cr-Commit-Position: refs/heads/master@{#394637}

Powered by Google App Engine
This is Rietveld 408576698