Issue 199104: Rollback webkit a few revisions to fix the dev tools....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199104: Rollback webkit a few revisions to fix the dev tools.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Rollback webkit a few revisions to fix the dev tools. Looks like http://trac.webkit.org/changeset/48314 busted things for us. TBR=brettw BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26059

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 3 months ago (2009-09-12 01:18:15 UTC) #2

Ah, this number is much better than the last. LGTM

On Fri, Sep 11, 2009 at 5:34 PM,  <darin@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Rollback webkit a few revisions to fix the dev tools.
>
> Looks like http://trac.webkit.org/changeset/48314 busted things
> for us.
>
> TBR=3Dbrettw
> BUG=3Dnone
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/199104
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 DEPS
>
>
> Index: DEPS
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- DEPS =A0 =A0 =A0 =A0(revision 26047)
> +++ DEPS =A0 =A0 =A0 =A0(working copy)
> @@ -1,7 +1,7 @@
> =A0vars =3D {
> =A0 "webkit_trunk":
> =A0 =A0 "http://svn.webkit.org/repository/webkit/trunk",
> - =A0"webkit_revision": "48317",
> + =A0"webkit_revision": "48313",
> =A0}
>
> =A0deps =3D {
>
>
>

Expand Messages | Collapse Messages