Issue 1991009: Shorten several apps-related flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1991009: Shorten several apps-related flags (Closed)

Created:
10 years, 7 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews, Erik does not do reviews

Visibility:
Public.

Description

Shorten several apps-related flags. "256 characters should be enough for anyone's shortcut flags!" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47079

Patch Set 1 #

Total comments: 3

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -43 lines)			Patch
M	chrome/browser/browser.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/shell_integration.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/utility_process_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/tabs/tab_renderer.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
	chrome/browser/views/tabs/tab_strip.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	3 chunks	+5 lines, -5 lines	2 comments	Download
M	chrome/common/chrome_switches.cc	View	4 chunks	+9 lines, -10 lines	1 comment	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

10 years, 7 months ago (2010-05-12 18:16:38 UTC) #2

lgtm

http://codereview.chromium.org/1991009/diff/1/14
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/1991009/diff/1/14#newcode44
chrome/common/chrome_switches.cc:44: const char kAppsPanel[]                    
= "apps-panel";
alphabetize

http://codereview.chromium.org/1991009/diff/1/15
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/1991009/diff/1/15#newcode29
chrome/common/chrome_switches.h:29: extern const char kAppsPanel[];
alphabetize

http://codereview.chromium.org/1991009/diff/1/15#newcode29
chrome/common/chrome_switches.h:29: extern const char kAppsPanel[];
consider kAppsLauncher to avoid confusion with kAppLaunchAsPanel.

Expand Messages | Collapse Messages