Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1990983002: array-iterator.js: use object_get_prototype_of instead of directly accessing the proto (Closed)

Created:
4 years, 7 months ago by gsathya
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

array-iterator.js: use object_get_prototype_of instead of directly accessing the proto Instead of directly looking up Uint8Array.__proto__, to get a hold of the TypedArray prototype, use object_get_prototype_of. This is a functionally equivalent, but cleaner approach. Committed: https://crrev.com/04aa9436ce01c3a6b793d45f9741cb6ae67916a1 Cr-Commit-Position: refs/heads/master@{#36340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990983002/1
4 years, 7 months ago (2016-05-18 19:19:17 UTC) #4
gsathya
This got lost in the revert of the typedarray optimization fix.
4 years, 7 months ago (2016-05-18 19:23:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 19:48:58 UTC) #7
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-18 21:02:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990983002/1
4 years, 7 months ago (2016-05-18 21:02:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 21:04:22 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 21:04:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04aa9436ce01c3a6b793d45f9741cb6ae67916a1
Cr-Commit-Position: refs/heads/master@{#36340}

Powered by Google App Engine
This is Rietveld 408576698