Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1990923002: [wasm] Refactor WASM run tests to allow them to run in the interpreter too. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactor WASM run tests to allow them to run in the interpreter too. R=mstarzinger@chromium.org,ahaas@chromium.org BUG= Committed: https://crrev.com/3fef34e02388e07d46067c516320f1ff12304c8e Cr-Commit-Position: refs/heads/master@{#36332}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -253 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 129 chunks +174 lines, -174 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 59 chunks +63 lines, -63 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-asmjs.cc View 12 chunks +12 lines, -16 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +9 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
titzer
4 years, 7 months ago (2016-05-18 15:12:53 UTC) #1
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-18 15:33:44 UTC) #2
ahaas
lgtm https://codereview.chromium.org/1990923002/diff/1/test/cctest/wasm/wasm-run-utils.h File test/cctest/wasm/wasm-run-utils.h (right): https://codereview.chromium.org/1990923002/diff/1/test/cctest/wasm/wasm-run-utils.h#newcode667 test/cctest/wasm/wasm-run-utils.h:667: TEST(RunWasmCompiled_##name) { RunWasm_##name(); } \ Could we use ...
4 years, 7 months ago (2016-05-18 15:43:26 UTC) #3
titzer
On 2016/05/18 15:43:26, ahaas wrote: > lgtm > > https://codereview.chromium.org/1990923002/diff/1/test/cctest/wasm/wasm-run-utils.h > File test/cctest/wasm/wasm-run-utils.h (right): > ...
4 years, 7 months ago (2016-05-18 15:53:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990923002/1
4 years, 7 months ago (2016-05-18 15:53:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 15:56:16 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 15:57:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fef34e02388e07d46067c516320f1ff12304c8e
Cr-Commit-Position: refs/heads/master@{#36332}

Powered by Google App Engine
This is Rietveld 408576698