Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1990913002: [NTP Snippets] Add variation params that override the default fetching intervals (Closed)

Created:
4 years, 7 months ago by Marc Treib
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, tschumann
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add variation params that override the default fetching intervals BUG=none Committed: https://crrev.com/558d88736f3c7f92cef540388d65a06421543ead Cr-Commit-Position: refs/heads/master@{#394426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M components/ntp_snippets/ntp_snippets_service.cc View 5 chunks +32 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990913002/1
4 years, 7 months ago (2016-05-18 14:24:18 UTC) #2
Marc Treib
PTAL!
4 years, 7 months ago (2016-05-18 14:25:53 UTC) #5
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-18 14:43:15 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 15:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990913002/1
4 years, 7 months ago (2016-05-18 15:20:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 15:23:48 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 15:25:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/558d88736f3c7f92cef540388d65a06421543ead
Cr-Commit-Position: refs/heads/master@{#394426}

Powered by Google App Engine
This is Rietveld 408576698