Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1990833002: Build speech recognizer library. (Closed)

Created:
4 years, 7 months ago by nellyv
Modified:
4 years, 7 months ago
Reviewers:
nelly, qsr, ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Build speech recognizer library. Before only the mojo application was built for the speech recognizer. We now build both the android library and .mojo file. R=ppi@chromium.org, qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f56fd59ec51e1ecdd52fb848ceff1b6b6fe7f7fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M services/speech_recognizer/BUILD.gn View 1 chunk +15 lines, -4 lines 0 comments Download
A services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizer.java View 1 chunk +19 lines, -0 lines 0 comments Download
M services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerApplicationDelegate.java View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nelly
Hi Ben and Przemek, Ptal.
4 years, 7 months ago (2016-05-18 12:13:41 UTC) #2
ppi
lgtm
4 years, 7 months ago (2016-05-18 12:46:23 UTC) #3
qsr
LGTM Thanks.
4 years, 7 months ago (2016-05-18 12:59:55 UTC) #4
nellyv
4 years, 7 months ago (2016-05-18 13:23:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f56fd59ec51e1ecdd52fb848ceff1b6b6fe7f7fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698