Issue 199083: Populate strings in gaia_login.html using jstemplates instead of literals....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199083: Populate strings in gaia_login.html using jstemplates instead of literals.... (Closed)

Created:
11 years, 3 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
Bruno, idana

CC:
chromium-reviews_googlegroups.com, ncarter (slow), Ben Goodger (Google), tim (not reviewing), idana, brunocalvignac_gmail.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Populate strings in gaia_login.html using jstemplates instead of literals. BUG=21494, 19896 TEST=SyncSetupWizardTest. Open sync wizard, ensure strings are present (error cases too). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25929

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -29 lines)			Patch
	M	chrome/browser/sync/resources/gaia_login.html	View	1 2 3	12 chunks	+28 lines, -28 lines	0 comments	Download
	M	chrome/browser/views/sync/sync_setup_wizard.cc	View	1 2 3	2 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

I thought this was going to be more work than it turned out to be. ...

11 years, 3 months ago (2009-09-10 20:49:02 UTC) #1

Bruno

10 years, 4 months ago (2010-07-28 22:58:29 UTC) #3

I have a suggestion for improvement (this can be used for all Chrome
localizations)

#define SetStr(st) SetString(L#st, l10n_util::GetString(IDS_SYNC_ ## st ##))

That way we can replace things like:
localized_strings.SetString(L"invalidcredentials",
        l10n_util::GetString(IDS_SYNC_INVALID_USER_CREDENTIALS));
with
localized_strings.SetStr(INVALID_USER_CREDENTIALS);

We then can use "INVALID_USER_CREDENTIALS" instead of "invalidcredentials" in
the html file, so it's simpler and more error proof.

 Bruno

Expand Messages | Collapse Messages