Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: src/bootstrapper.cc

Issue 1990803005: [runtime] set AsyncFunctionNext/Throw to adapt arguments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Also, don't expose AsyncFunctionNext/AsyncFunctionThrow in stack trace Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/async-debug-basic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index b96b834505c0ab62d528d74add2207a4d218e2e7..328ff63cd9d9059d22394e56a56e9a52eeb18ff4 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2466,12 +2466,12 @@ void Bootstrapper::ExportFromRuntime(Isolate* isolate,
Handle<JSFunction> async_function_next =
SimpleInstallFunction(container, "AsyncFunctionNext",
- Builtins::kGeneratorPrototypeNext, 2, false);
+ Builtins::kGeneratorPrototypeNext, 1, true);
Handle<JSFunction> async_function_throw =
SimpleInstallFunction(container, "AsyncFunctionThrow",
- Builtins::kGeneratorPrototypeThrow, 2, false);
- async_function_next->shared()->set_native(true);
- async_function_throw->shared()->set_native(true);
+ Builtins::kGeneratorPrototypeThrow, 1, true);
+ async_function_next->shared()->set_native(false);
adamk 2016/09/27 23:57:11 I found it surprising that this was done to _keep_
caitp 2016/09/28 00:01:18 See IsNotInNativeScript() and IsVisibleInStackTrac
adamk 2016/09/28 00:03:15 Ah, so "native" means "native but exposed to autho
+ async_function_throw->shared()->set_native(false);
}
}
}
« no previous file with comments | « no previous file | test/mjsunit/harmony/async-debug-basic.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698