Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/bootstrapper.cc

Issue 1990803005: [runtime] set AsyncFunctionNext/Throw to adapt arguments (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rework to support all functions without arguments adapter frames Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index b96b834505c0ab62d528d74add2207a4d218e2e7..48639468c368bfa47ba94c1f0f7d334d4f7da2d8 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2466,10 +2466,10 @@ void Bootstrapper::ExportFromRuntime(Isolate* isolate,
Handle<JSFunction> async_function_next =
SimpleInstallFunction(container, "AsyncFunctionNext",
- Builtins::kGeneratorPrototypeNext, 2, false);
+ Builtins::kGeneratorPrototypeNext, 1, false);
Dan Ehrenberg 2016/05/18 18:58:02 1 looks like the right value here, matching the ot
caitp (gmail) 2016/05/18 19:03:43 The original implementation used a parameter for t
Handle<JSFunction> async_function_throw =
SimpleInstallFunction(container, "AsyncFunctionThrow",
- Builtins::kGeneratorPrototypeThrow, 2, false);
+ Builtins::kGeneratorPrototypeThrow, 1, false);
async_function_next->shared()->set_native(true);
async_function_throw->shared()->set_native(true);
}
« no previous file with comments | « no previous file | src/frames.cc » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698