Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1990803003: Files app: Use custom iron-iconset-svg for iron-icons. (Closed)

Created:
4 years, 7 months ago by fukino
Modified:
4 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Use custom iron-iconset-svg for iron-icons. BUG=612068 TEST=manually confirmed the replaced icons. Committed: https://crrev.com/be3e68926a236bfaaf85240efd1e034733e7699b Cr-Commit-Position: refs/heads/master@{#394365}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -18 lines) Patch
M ui/file_manager/file_manager/foreground/elements/elements_bundle.html View 2 chunks +1 line, -2 lines 0 comments Download
A ui/file_manager/file_manager/foreground/elements/icons.html View 1 chunk +25 lines, -0 lines 1 comment Download
M ui/file_manager/file_manager/foreground/js/import_controller.js View 6 chunks +12 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/combobutton.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
fukino
yawano@: PTAL. Thanks! https://codereview.chromium.org/1990803003/diff/1/ui/file_manager/file_manager/foreground/elements/icons.html File ui/file_manager/file_manager/foreground/elements/icons.html (right): https://codereview.chromium.org/1990803003/diff/1/ui/file_manager/file_manager/foreground/elements/icons.html#newcode16 ui/file_manager/file_manager/foreground/elements/icons.html:16: <g id="arrow-drop-down"><path d="M7 10l5 5 5-5z"/></g> ...
4 years, 7 months ago (2016-05-18 07:25:29 UTC) #3
fukino
yawano@: PTAL. Thanks!
4 years, 7 months ago (2016-05-18 07:25:31 UTC) #4
yawano
lgtm. Thank you!
4 years, 7 months ago (2016-05-18 08:08:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990803003/1
4 years, 7 months ago (2016-05-18 08:54:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 08:58:57 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 09:00:07 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be3e68926a236bfaaf85240efd1e034733e7699b
Cr-Commit-Position: refs/heads/master@{#394365}

Powered by Google App Engine
This is Rietveld 408576698