Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1990793002: Forward declare ShellClient for MojoApplicationInfo (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declare ShellClient for MojoApplicationInfo This avoids pulling in generated headers indirectly through content_browser_client.h, which can be problematic because gyp makes it hard to reason about how these dependencies are propagated. BUG=612689 R=amistry@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518 Cr-Commit-Position: refs/heads/master@{#394359}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M content/public/common/mojo_application_info.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/common/mojo_application_info.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-18 06:11:54 UTC) #1
Anand Mistry (off Chromium)
lgtm
4 years, 7 months ago (2016-05-18 06:13:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990793002/1
4 years, 7 months ago (2016-05-18 06:13:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990793002/20001
4 years, 7 months ago (2016-05-18 06:21:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990793002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990793002/2
4 years, 7 months ago (2016-05-18 07:09:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:2)
4 years, 7 months ago (2016-05-18 08:14:33 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 08:16:54 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf869a0ff45baa0b1f973ab6dd5befcd5dd2f518
Cr-Commit-Position: refs/heads/master@{#394359}

Powered by Google App Engine
This is Rietveld 408576698