Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1990743003:
Support fullscreen in webview shell. (Closed)
|
Created:
4 years, 7 months ago by Tobias Sargeant Modified:
4 years, 7 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSupport fullscreen in webview shell.
BUG=612587
Committed: https://crrev.com/6a321a7e3cfe5b7272da3c0f99cf200ee09927fd
Cr-Commit-Position: refs/heads/master@{#394731}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Cope with the possibibility that onShowCustomView and onHideCustomView calls might not be paired #
Messages
Total messages: 15 (6 generated)
tobiasjs@chromium.org changed reviewers: + timav@chromium.org
Hi Tima, Coincidentally I needed fullscreen mode today to smoke test the functor refactoring. Then I saw that you took a bug to support that for video, so I thought I'd pass this to you. It might need more work (this isn't really my area), but it appears to work.
Thank you for fixing it. lgtm
timvolodine@chromium.org changed reviewers: + timvolodine@chromium.org
lgtm % comment https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... File android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java (right): https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:269: ((ViewGroup) mFullscreenView.getParent()).removeView(mFullscreenView); does mFullscreenView need to be set to null here?
timvolodine@chromium.org changed reviewers: + boliu@chromium.org
+ boliu@ to double-check as he has commented on the original bug
https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... File android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java (right): https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:257: mFullscreenView = view; if mFullscreenView is non null, detach it first
https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... File android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java (right): https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:257: mFullscreenView = view; On 2016/05/18 18:09:11, boliu_OOO_back_May31 wrote: > if mFullscreenView is non null, detach it first Done. https://codereview.chromium.org/1990743003/diff/1/android_webview/tools/syste... android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:269: ((ViewGroup) mFullscreenView.getParent()).removeView(mFullscreenView); On 2016/05/18 17:56:57, timvolodine wrote: > does mFullscreenView need to be set to null here? Done.
The CQ bit was checked by tobiasjs@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from timav@chromium.org, timvolodine@chromium.org Link to the patchset: https://codereview.chromium.org/1990743003/#ps20001 (title: "Cope with the possibibility that onShowCustomView and onHideCustomView calls might not be paired")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990743003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Support fullscreen in webview shell. BUG=612587 ========== to ========== Support fullscreen in webview shell. BUG=612587 Committed: https://crrev.com/6a321a7e3cfe5b7272da3c0f99cf200ee09927fd Cr-Commit-Position: refs/heads/master@{#394731} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6a321a7e3cfe5b7272da3c0f99cf200ee09927fd Cr-Commit-Position: refs/heads/master@{#394731} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
