[Android] Set up blimp client unit tests on chromium.linux

[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
Committed: https://crrev.com/12b2cca03e3f4a114ffeb7a9472fda1f0d77c540
Cr-Commit-Position: refs/heads/master@{#394854}

[shenghuazhang, 2016-05-18 01:40:42]

shenghuazhang@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-05-18 14:20:44]

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:327: "apk_under_test": "Blimp.apk",
I don't think apk_under_test or test_apk are necessary here, but
override_compile_targets currently is.

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:470: "apk_under_test": "Blimp.apk",
(same here)

[jbudorick, 2016-05-18 17:25:22]

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:327: "apk_under_test": "Blimp.apk",
On 2016/05/18 14:20:44, jbudorick wrote:
> I don't think apk_under_test or test_apk are necessary here, but
> override_compile_targets currently is.

Actually, leave override_compile_targets out. I'm going to make an infra-side
change s.t. this works with just "test": "blimp_test_apk"

[shenghuazhang, 2016-05-18 17:59:34]

The CQ bit was checked by shenghuazhang@chromium.org

[shenghuazhang, 2016-05-18 17:59:36]

The CQ bit was unchecked by shenghuazhang@chromium.org

[shenghuazhang, 2016-05-18 18:00:46]

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:327: "apk_under_test": "Blimp.apk",
On 2016/05/18 at 17:25:21, jbudorick wrote:
> On 2016/05/18 14:20:44, jbudorick wrote:
> > I don't think apk_under_test or test_apk are necessary here, but
> > override_compile_targets currently is.
> 
> Actually, leave override_compile_targets out. I'm going to make an infra-side
change s.t. this works with just "test": "blimp_test_apk"

Done. Just leave "test": "blimp_test_apk" here.

https://codereview.chromium.org/1990743002/diff/1/testing/buildbot/chromium.l...
testing/buildbot/chromium.linux.json:470: "apk_under_test": "Blimp.apk",
On 2016/05/18 at 14:20:44, jbudorick wrote:
> (same here)

Done.

[jbudorick, 2016-05-18 18:07:47]

changes look fine % https://codereview.chromium.org/1994703002/ landing.

Please update the title s.t. it's clear that this is Android-specific.

[shenghuazhang, 2016-05-18 18:11:27]

Description was changed from

==========
Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

to

==========
Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

[jbudorick, 2016-05-19 14:09:35]

On 2016/05/18 18:07:47, jbudorick wrote:
> changes look fine % https://codereview.chromium.org/1994703002/ landing.

This has landed. lgtm

> 
> Please update the title s.t. it's clear that this is Android-specific.

but still update the title before landing

[jbudorick, 2016-05-19 15:27:30]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org

[jbudorick, 2016-05-19 15:27:31]

also, +Dirk for owners

[shenghuazhang, 2016-05-19 17:43:46]

Description was changed from

==========
Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

to

==========
[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

[shenghuazhang, 2016-05-19 17:46:23]

The CQ bit was checked by shenghuazhang@chromium.org

[shenghuazhang, 2016-05-19 17:46:39]

The CQ bit was unchecked by shenghuazhang@chromium.org

[shenghuazhang, 2016-05-19 17:48:41]

The CQ bit was checked by shenghuazhang@chromium.org

[shenghuazhang, 2016-05-19 17:49:00]

The CQ bit was unchecked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2016-05-19 17:49:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990743002/20001

[shenghuazhang, 2016-05-19 18:07:46]

The CQ bit was checked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2016-05-19 18:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990743002/20001

[commit-bot: I haz the power, 2016-05-19 18:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 18:17:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shenghuazhang, 2016-05-19 18:19:31]

The CQ bit was unchecked by shenghuazhang@chromium.org

[Dirk Pranke, 2016-05-19 18:32:09]

lgtm

[shenghuazhang, 2016-05-19 18:49:11]

The CQ bit was checked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2016-05-19 18:49:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990743002/20001

[commit-bot: I haz the power, 2016-05-19 20:47:30]

Description was changed from

==========
[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

to

==========
[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

[commit-bot: I haz the power, 2016-05-19 20:47:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 20:48:42]

Description was changed from

==========
[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550
==========

to

==========
[Android] Set up blimp client unit tests on chromium.linux

In chromium.linux buildbot, set up "blimp_unittests" (gtest_tests) and
"blimp_test_apk" (instrumentation_tests) in 2 testers Android Tests and
Android Tests (dbg)

BUG=612550

Committed: https://crrev.com/12b2cca03e3f4a114ffeb7a9472fda1f0d77c540
Cr-Commit-Position: refs/heads/master@{#394854}
==========

[commit-bot: I haz the power, 2016-05-19 20:48:44]

Patchset 2 (id:??) landed as
https://crrev.com/12b2cca03e3f4a114ffeb7a9472fda1f0d77c540
Cr-Commit-Position: refs/heads/master@{#394854}